-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material-experimental/mdc-chips): decouple removal from animation #21636
fix(material-experimental/mdc-chips): decouple removal from animation #21636
Conversation
7ea16d6
to
96fe14e
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
…angular#21636) * fix(material-experimental/mdc-chips): decouple removal from animation * fixup! fix(material-experimental/mdc-chips): decouple removal from animation Co-authored-by: Kristiyan Kostadinov <crisbeto@abv.bg>
…angular#21636) * fix(material-experimental/mdc-chips): decouple removal from animation * fixup! fix(material-experimental/mdc-chips): decouple removal from animation Co-authored-by: Kristiyan Kostadinov <crisbeto@abv.bg>
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently the MDC chips automatically trigger an animation that collapses the chip to 0x0 dimensions, but it still keeps it in the DOM unless the consumer updates their data source. This is misleading and there's no way for the consumer to see it.
These changes bring the chip in line with our current behavior where we only dispatch the remove event and then it's up to the consumer to remove the chip.
Making these changes also revealed some tests that were passing by accident and weren't actually testing the things they were supposed to, because the
animationend
event wasn't being dispatched. I've tweaked them in order to get them to work as expected.Fixes #21561.
CARETAKER NOTE: This was previously merged and broke internal tests. Pantheon's harnesses will need to be updated to work with this change